♿(frontend) add skip to content button for keyboard accessibility #1624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -56 B (0%) Total Size: 4.07 MB
|
Ovgodd
force-pushed
the
fix/1621-a11y-skip-link
branch
4 times, most recently
from
ddf3bdd to
46a87ac
Compare
Ovgodd
force-pushed
the
fix/1621-a11y-skip-link
branch
from
46a87ac to
6cf81b3
Compare
Ovgodd
force-pushed
the
fix/1621-a11y-skip-link
branch
from
6cf81b3 to
7bd9674
Compare
Ovgodd
changed the title
Ovgodd
force-pushed
the
fix/1621-a11y-skip-link
branch
from
7bd9674 to
7311d97
Compare
add SkipToContent component to meet RGAA skiplink requirement Signed-off-by: Cyril <[email protected]>
ensures skiplink behavior is tested and stabilizes a failing accessibility test Signed-off-by: Cyril <[email protected]>
Ovgodd
force-pushed
the
fix/1621-a11y-skip-link
branch
from
7311d97 to
470b4cb
Compare
AntoLC
reviewed
Nov 25, 2025
Ovgodd
force-pushed
the
fix/1621-a11y-skip-link
branch
from
c4acc55 to
6dc9a6b
Compare
AntoLC
approved these changes
Nov 26, 2025
| data-testid="header-logo-link" | ||
| aria-label={t('Back to homepage')} | ||
| <> | ||
| <SkipToContent /> |
Collaborator
There was a problem hiding this comment.
I guess it should be in HomeHeader as well, no?
| style={{ | ||
| opacity: isVisible ? 1 : 0, | ||
| pointerEvents: isVisible ? 'auto' : 'none', | ||
| transition: 'opacity 0.3s ease-in-out', |
Collaborator
There was a problem hiding this comment.
Button has already a transition.
Comment on lines
+52
to
+56
| position: 'fixed', | ||
| top: 'var(--c--theme--spacings--2xs)', | ||
| // padding header + logo(32px) + gap(3xs≈4px) + text "Docs"(≈70px) + 12px | ||
| left: 'calc(var(--c--theme--spacings--base) + 32px + var(--c--theme--spacings--3xs) + 70px + 12px)', | ||
| zIndex: 9999, |
Collaborator
There was a problem hiding this comment.
Let's do like that, but yes I am not huge fond of this part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Introduce a keyboard-accessible skip link to improve navigation and comply with RGAA.
issue 1621
skiplinkpages_Yk5ZTCDR.mp4
Proposal
SkipToContentcomponent